Re: [PATCH v2 1/1] driver core: Drop unneeded 'extern' keyword in fwnode.h

From: Saravana Kannan
Date: Tue Feb 20 2024 - 19:53:18 EST


On Tue, Feb 20, 2024 at 9:53 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> We do not use 'extern' keyword with functions. Remove the last one
> mistakenly added to fwnode.h.
>
> Fixes: 19d0f5f6bff8 ("driver core: Add fw_devlink.strict kernel param")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Acked-by: Saravana Kannan <saravanak@xxxxxxxxxx>

> ---
> v2: fixed a couple of typos in the Subject
> include/linux/fwnode.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
> index 2a72f55d26eb..2d23a14857c7 100644
> --- a/include/linux/fwnode.h
> +++ b/include/linux/fwnode.h
> @@ -209,9 +209,9 @@ static inline void fwnode_dev_initialized(struct fwnode_handle *fwnode,
> fwnode->flags &= ~FWNODE_FLAG_INITIALIZED;
> }
>
> -extern bool fw_devlink_is_strict(void);
> int fwnode_link_add(struct fwnode_handle *con, struct fwnode_handle *sup);
> void fwnode_links_purge(struct fwnode_handle *fwnode);
> void fw_devlink_purge_absent_suppliers(struct fwnode_handle *fwnode);
> +bool fw_devlink_is_strict(void);
>
> #endif
> --
> 2.43.0.rc1.1.gbec44491f096
>