Re: [PATCH v7 1/2] drivers: rtc: add max313xx series rtc driver
From: kernel test robot
Date: Tue Feb 20 2024 - 17:58:35 EST
Hi Chris,
kernel test robot noticed the following build warnings:
[auto build test WARNING on abelloni/rtc-next]
[also build test WARNING on linus/master v6.8-rc5 next-20240220]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Chris-Packham/drivers-rtc-add-max313xx-series-rtc-driver/20240220-062057
base: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
patch link: https://lore.kernel.org/r/20240219221827.3821415-2-chris.packham%40alliedtelesis.co.nz
patch subject: [PATCH v7 1/2] drivers: rtc: add max313xx series rtc driver
config: x86_64-randconfig-123-20240220 (https://download.01.org/0day-ci/archive/20240221/202402210633.wquhPF22-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240221/202402210633.wquhPF22-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402210633.wquhPF22-lkp@xxxxxxxxx/
sparse warnings: (new ones prefixed by >>)
>> drivers/rtc/rtc-max31335.c:727:22: sparse: sparse: symbol 'max313xx_clk_init' was not declared. Should it be static?
>> drivers/rtc/rtc-max31335.c:750:21: sparse: sparse: symbol 'max313xx_nvmem_cfg' was not declared. Should it be static?
vim +/max313xx_clk_init +727 drivers/rtc/rtc-max31335.c
726
> 727 struct clk_init_data max313xx_clk_init = {
728 .name = "max313xx-clkout",
729 .ops = &max313xx_clkout_ops,
730 };
731
732 static int max313xx_nvmem_reg_read(void *priv, unsigned int offset,
733 void *val, size_t bytes)
734 {
735 struct max313xx *rtc = priv;
736 unsigned int reg = rtc->chip->ram_reg + offset;
737
738 return regmap_bulk_read(rtc->regmap, reg, val, bytes);
739 }
740
741 static int max313xx_nvmem_reg_write(void *priv, unsigned int offset,
742 void *val, size_t bytes)
743 {
744 struct max313xx *rtc = priv;
745 unsigned int reg = rtc->chip->ram_reg + offset;
746
747 return regmap_bulk_write(rtc->regmap, reg, val, bytes);
748 }
749
> 750 struct nvmem_config max313xx_nvmem_cfg = {
751 .reg_read = max313xx_nvmem_reg_read,
752 .reg_write = max313xx_nvmem_reg_write,
753 .word_size = 8,
754 };
755
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki