Re: [PATCH net-next v4 1/9] net: usb: r8152: Use linkmode helpers for EEE

From: Simon Horman
Date: Tue Feb 20 2024 - 07:56:24 EST


On Sun, Feb 18, 2024 at 11:06:58AM -0600, Andrew Lunn wrote:
> Make use of the existing linkmode helpers for converting PHY EEE
> register values into links modes, now that ethtool_keee uses link
> modes, rather than u32 values.
>
> Rework determining if EEE is active to make is similar as to how
> phylib decides, and make use of a phylib helper to validate if EEE is
> valid in for the current link mode. This then requires that PHYLIB is
> selected.
>
> Signed-off-by: Andrew Lunn <andrew@xxxxxxx>

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>