RE: [PATCH v2] interconnect: constify of_phandle_args in xlate

From: Alim Akhtar
Date: Tue Feb 20 2024 - 07:18:34 EST




> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Tuesday, February 20, 2024 12:52 PM
> To: Georgi Djakov <djakov@xxxxxxxxxx>; Bjorn Andersson
> <andersson@xxxxxxxxxx>; Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>;
> Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>; Artur Świgoń
> <a.swigon@xxxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx>; Alim Akhtar
> <alim.akhtar@xxxxxxxxxxx>; Thierry Reding <thierry.reding@xxxxxxxxx>;
> Jonathan Hunter <jonathanh@xxxxxxxxxx>; linux-pm@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; linux-arm-msm@xxxxxxxxxxxxxxx; linux-
> samsung-soc@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> tegra@xxxxxxxxxxxxxxx
> Cc: Thierry Reding <treding@xxxxxxxxxx>
> Subject: [PATCH v2] interconnect: constify of_phandle_args in xlate
>
> The xlate callbacks are supposed to translate of_phandle_args to proper
> provider without modifying the of_phandle_args. Make the argument
> pointer to const for code safety and readability.
>
> Acked-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> Acked-by: Thierry Reding <treding@xxxxxxxxxx> # Tegra
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> ---
>
> Changes in v2:
> 1. Drop unrelated gpiolib changes (Konrad, Thierry).
> 2. Add tags.
> ---
> drivers/interconnect/core.c | 4 ++--
> drivers/interconnect/qcom/icc-common.c | 3 ++-
> drivers/interconnect/qcom/icc-common.h | 3 ++-
> drivers/interconnect/samsung/exynos.c | 2 +-
> drivers/memory/tegra/mc.c | 2 +-
> drivers/memory/tegra/tegra124-emc.c | 2 +-
> drivers/memory/tegra/tegra124.c | 2 +-
> drivers/memory/tegra/tegra186-emc.c | 2 +-
> drivers/memory/tegra/tegra20-emc.c | 2 +-
> drivers/memory/tegra/tegra20.c | 2 +-
> drivers/memory/tegra/tegra30-emc.c | 2 +-
> drivers/memory/tegra/tegra30.c | 2 +-
> include/linux/interconnect-provider.h | 11 ++++++-----
> include/soc/tegra/mc.h | 7 ++++---
> 14 files changed, 25 insertions(+), 21 deletions(-)
>

For Samsung/Exynos
Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
.
.
[snip]
> --
> 2.34.1