[PATCH v3] irqchip/mbigen: Don't use bus_get_dev_root() to find the parent

From: 陈骏
Date: Tue Feb 20 2024 - 06:22:29 EST


From: Chen Jun <chenjun102@xxxxxxxxxx>

bus_get_dev_root() returns sp->dev_root set in subsys_register().
And subsys_register() is not called by platform_bus_init().

For platform_bus_type, bus_get_dev_root() always returns NULL.
This makes mbigen_of_create_domain() always return -ENODEV.

Don't try to retrieve the parent via bus_get_dev_root() and
unconditionally hand a NULL pointer to of_platform_device_create() to
fix this.

Fixes: fea087fc291b ("irqchip/mbigen: move to use bus_get_dev_root()")
Signed-off-by: Chen Jun <chenjun102@xxxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx
---
v3: Modify change log

v2: Modify change log
https://lore.kernel.org/all/20240219085314.85363-1-chenjun102@xxxxxxxxxx/

v1: https://lore.kernel.org/all/20240129130003.18181-1-chenjun102@xxxxxxxxxx/

drivers/irqchip/irq-mbigen.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c
index 5101a3fb11df..58881d313979 100644
--- a/drivers/irqchip/irq-mbigen.c
+++ b/drivers/irqchip/irq-mbigen.c
@@ -235,22 +235,17 @@ static const struct irq_domain_ops mbigen_domain_ops = {
static int mbigen_of_create_domain(struct platform_device *pdev,
struct mbigen_device *mgn_chip)
{
- struct device *parent;
struct platform_device *child;
struct irq_domain *domain;
struct device_node *np;
u32 num_pins;
int ret = 0;

- parent = bus_get_dev_root(&platform_bus_type);
- if (!parent)
- return -ENODEV;
-
for_each_child_of_node(pdev->dev.of_node, np) {
if (!of_property_read_bool(np, "interrupt-controller"))
continue;

- child = of_platform_device_create(np, NULL, parent);
+ child = of_platform_device_create(np, NULL, NULL);
if (!child) {
ret = -ENOMEM;
break;
@@ -273,7 +268,6 @@ static int mbigen_of_create_domain(struct platform_device *pdev,
}
}

- put_device(parent);
if (ret)
of_node_put(np);

--
2.17.1