Re: [RFC PATCH 5/6] arm64: dts: qcom: add base AIM500 dtsi

[Aiqun Yu (Maria)]

On 2/20/2024 6:06 PM, Jingyi Wang wrote:
> Hi Dmitry,
>
> On 2/20/2024 5:19 PM, Dmitry Baryshkov wrote:
> > On Tue, 20 Feb 2024 at 11:17, Jingyi Wang <quic_jingyw@xxxxxxxxxxx> wrote:
> > > Hi Dmitry,
> > >
> > > On 2/5/2024 10:23 PM, Dmitry Baryshkov wrote:
> > > > On Mon, 5 Feb 2024 at 14:00, Jingyi Wang <quic_jingyw@xxxxxxxxxxx> wrote:
> > > > > Introduce aim500 board dtsi.
> > > >
> > > > So, is it a board or a module?
> > > aim500 is a module, will fix the descrption.
> > >
> > > > > AIM500 Series is a highly optimized family of modules designed to
> > > > > support AIoT and Generative AI applications based on sm8650p with
> > > > > PMIC and bluetooth functions etc.
> > > > >
> > > > > Co-developed-by: Tingwei Zhang <quic_tingweiz@xxxxxxxxxxx>
> > > > > Signed-off-by: Tingwei Zhang <quic_tingweiz@xxxxxxxxxxx>
> > > > > Signed-off-by: Jingyi Wang <quic_jingyw@xxxxxxxxxxx>
> > > > > ---
> > > > >   arch/arm64/boot/dts/qcom/sm8650p-aim500.dtsi | 409 +++++++++++++++++++
> > > > >   1 file changed, 409 insertions(+)
> > > > >   create mode 100644 arch/arm64/boot/dts/qcom/sm8650p-aim500.dtsi
> > > > >
> > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8650p-aim500.dtsi b/arch/arm64/boot/dts/qcom/sm8650p-aim500.dtsi
> > > > > new file mode 100644
> > > > > index 000000000000..cb857da8653b
> > > > > --- /dev/null
> > > > > +++ b/arch/arm64/boot/dts/qcom/sm8650p-aim500.dtsi
> > > > > @@ -0,0 +1,409 @@
> > > > > +// SPDX-License-Identifier: BSD-3-Clause
> > > > > +/*
> > > > > + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved.
> > > > > + */
> > > > > +
> > > > > +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> > > > > +#include "sm8650p.dtsi"
> > > > > +#include "pm8550.dtsi"
> > > > > +#include "pm8550b.dtsi"
> > > > > +#define PMK8550VE_SID 8
> > > > > +#include "pm8550ve.dtsi"
> > > > > +#include "pm8550vs.dtsi"
> > > > > +#include "pmk8550.dtsi"
> > > > > +
> > > > > +/ {
> > > > > +       aliases {
> > > > > +               serial1 = &uart14;
> > > > > +       };
> > > > > +
> > > > > +       vph_pwr: vph-pwr-regulator { };
> > > >
> > > > Is this regulator a part of the module or a part of the carrier board?
> > > > If the latter is true, this must go to the carrier board DT file.
> > >
> > > the vph_pwr regulator is defined in the aim500-aiot carrier board and used
> > > in aim500 module.
> >
> > If it is defined in the carrier board, then please move it and
> > corresponding supply entries to the carrier board dts. Other devices
> > using the SoM can have different power tree.
> >
> > While we are at it, could you please rename the node to regulator-vph-pwr?
> will rename the node and move it to sm8650p-aim500-aiot.dts

Shall we have the VPH_PWR implementation inside the board dts file, and 
have the supply entries which used the VPH_PWR inside the SOM.dtsi file?

The VPH_PWR is an input IO of SOM. And the corresponding supply entries 
is inside the SOM hardware design as well.

The VPH_PWR as a fixed regulator implementation is the board design, it 
can be changed to other design from different boards.

Here is a simple diagram to show the hardware description of the VPH_PWR 
related design:

+------------------------------------------------------+ 


|                 Board                                | 


|                                                      | 


|           +-----------------+                        | 


|power----->| Fixed regulator-----------+              | 


|           +-----------------+         |              | 


|                                       |              | 


|                                       v VPH_PWR      | 


|                  +------|----------------------+     | 


|                  |      |    SOM       |       |     | 


|                  |      |              |       |     | 


|                  |      vVPH_PWR       vVPM_PWR|     | 


|                  |  +------+       +------+    |     | 


|                  |  | pmic1|       |pmic2 |    |     | 


|                  |  +------+       +------+    |     | 


|                  |                             |     | 


|                  +-----------------------------+     | 


+------------------------------------------------------+ 




> Thanks,
> Jingyi

--
Thx and BRs,
Aiqun(Maria) Yu