Re: [PATCH v3 0/3] scripts: check-sysctl-docs: adapt to new API

From: Joel Granados
Date: Tue Feb 20 2024 - 04:01:27 EST


Hey Thomas

Thx for your V3. I'll put it on my sysctl todo list for friday.

Best

On Mon, Feb 19, 2024 at 09:19:21PM +0100, Thomas Weißschuh wrote:
> The script expects the old sysctl_register_paths() API which was removed
> some time ago. Adapt it to work with the new
> sysctl_register()/sysctl_register_sz()/sysctl_register_init() APIs.
>
> Per-namespace tables via __register_sysctl_table() are also handled.
>
> Note that the script is already prepared for a potential constification
> of the ctl_table structs.
>
> Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> ---
> Changes in v3:
> - Handle per-namespace tables
> - Link to v2: https://lore.kernel.org/r/20231226-sysctl-check-v2-1-2d4f50b30d34@xxxxxxxxxxxxxx
>
> Changes in v2:
> - Remove unused global variable "paths"
> - Remove docs for deleted variables "children" and "paths"
> - Link to v1: https://lore.kernel.org/r/20231220-sysctl-check-v1-1-420ced4a69d7@xxxxxxxxxxxxxx
>
> ---
> Thomas Weißschuh (3):
> scripts: check-sysctl-docs: adapt to new API
> ipc: remove linebreaks from arguments of __register_sysctl_table
> scripts: check-sysctl-docs: handle per-namespace sysctls
>
> ipc/ipc_sysctl.c | 3 +--
> scripts/check-sysctl-docs | 65 +++++++++++++++++++++++------------------------
> 2 files changed, 33 insertions(+), 35 deletions(-)
> ---
> base-commit: b401b621758e46812da61fa58a67c3fd8d91de0d
> change-id: 20231220-sysctl-check-8802651d945d
>
> Best regards,
> --
> Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
>

--

Joel Granados

Attachment: signature.asc
Description: PGP signature