Re: [PATCH] can: raw: raw_getsockopt(): reduce scope of err

From: Marc Kleine-Budde
Date: Tue Feb 20 2024 - 03:42:44 EST


On 20.02.2024 17:27:05, Vincent Mailhol wrote:
> On Tue. 20 Feb. 2024 at 17:16, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
> > Reduce the scope of the variable "err" to the individual cases. This
> > is to avoid the mistake of setting "err" in the mistaken belief that
> > it will be evaluated later.
> >
> > Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
>
> One nitpick to remove a newline, but aside from that:
>
> Reviewed-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>
>
> (as usual, I do not mind if the nitpick gets resolved while applying).

Thanks for the review, fixed that while applying.

regards,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |

Attachment: signature.asc
Description: PGP signature