Re: [PATCH] sparc: Fix undefined reference to fb_is_primary_device

From: Arnd Bergmann
Date: Tue Feb 20 2024 - 03:41:35 EST


On Tue, Feb 20, 2024, at 01:34, Javier Martinez Canillas wrote:
> Commit 55bffc8170bb ("fbdev: Split frame buffer support in FB and FB_CORE
> symbols") added a new FB_CORE Kconfig symbol, that can be enabled to only
> have fbcon/VT and DRM fbdev emulation, but without support for any legacy
> fbdev driver.
>
> Unfortunately, it missed to change a CONFIG_FB in arch/sparc/Makefile and
> that leads to the following linking error in some sparc64 configurations:
>
> sparc64-linux-ld: drivers/video/fbdev/core/fbcon.o: in function
> `fbcon_fb_registered':
>>> fbcon.c:(.text+0x4f60): undefined reference to `fb_is_primary_device'
>
> Fixes: 55bffc8170bb ("fbdev: Split frame buffer support in FB and
> FB_CORE symbols")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/r/202401290306.IV8rhJ02-lkp@xxxxxxxxx/
> Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

Acked-by; Arnd Bergmann <arnd@xxxxxxxx>