Re: [PATCH v5 4/4] pinctrl: nuvoton: Add ma35d1 pinctrl and GPIO driver

From: Krzysztof Kozlowski
Date: Tue Feb 20 2024 - 03:28:51 EST


On 20/02/2024 01:41, Jacky Huang wrote:
> From: Jacky Huang <ychuang3@xxxxxxxxxxx>
>
> Add common pinctrl and GPIO driver for Nuvoton MA35 series SoC, and
> add support for ma35d1 pinctrl.
>
> Signed-off-by: Jacky Huang <ychuang3@xxxxxxxxxxx>
> ---
> drivers/pinctrl/nuvoton/Kconfig | 19 +
> drivers/pinctrl/nuvoton/Makefile | 2 +
> drivers/pinctrl/nuvoton/pinctrl-ma35.c | 1211 +++++++++++++++
> drivers/pinctrl/nuvoton/pinctrl-ma35.h | 51 +
> drivers/pinctrl/nuvoton/pinctrl-ma35d1.c | 1797 ++++++++++++++++++++++
> 5 files changed, 3080 insertions(+)
> create mode 100644 drivers/pinctrl/nuvoton/pinctrl-ma35.c
> create mode 100644 drivers/pinctrl/nuvoton/pinctrl-ma35.h
> create mode 100644 drivers/pinctrl/nuvoton/pinctrl-ma35d1.c

Driver cannot depend on DTS, so please reorganize patchset so DTS is not
in the middle or even split the DTS to separate patchset.

Best regards,
Krzysztof