Re: [PATCH RFC v3 1/5] dt-bindings: phy: hisi-inno-usb2: convert to YAML

[Yang Xiwen]

On 2/20/2024 5:36 AM, Krzysztof Kozlowski wrote:
> On 19/02/2024 22:33, Yang Xiwen wrote:
> > On 2/20/2024 5:30 AM, Krzysztof Kozlowski wrote:
> > > On 19/02/2024 22:27, Yang Xiwen via B4 Relay wrote:
> > > > From: Yang Xiwen <forbidden405@xxxxxxxxxxx>
> > > >
> > > > Add missing compatible "hisilicon,hi3798mv100-usb2-phy" to compatible
> > > > list due to prior driver change.
> > > >
> > > > Also rename to hisilicon,inno-usb2-phy.yaml and add this name to
> > > > compatible lists.
> > > >
> > > > Fixes: 3940ffc65492 ("phy: hisilicon: Add inno-usb2-phy driver for Hi3798MV100")
> > > I don't understand what is the bug being fixed here. Binding being in
> > > TXT is not a bug.
> > This commit adds the compatible "hisilicon,hi3798mv100-usb2-phy" to the
> > driver, but binding change is left alone.
> Then this patch is not a correct fix. It does something else then adding
> missing compatible. Remember that one commit is one logical change.
Okay, that's fine. I'll break them into 2 patches.
> Best regards,
> Krzysztof

--
Regards,
Yang Xiwen