Re: [RESEND PATCH v2] iio: gts-helper: Fix division loop

From: Jonathan Cameron
Date: Mon Feb 19 2024 - 14:33:16 EST


On Mon, 19 Feb 2024 09:22:24 +0200
Matti Vaittinen <mazziesaccount@xxxxxxxxx> wrote:

> On 2/18/24 07:26, Subhajit Ghosh wrote:
> > On 18/2/24 02:57, Jonathan Cameron wrote:
> >> On Sun, 18 Feb 2024 01:09:33 +1030
> >> Subhajit Ghosh <subhajit.ghosh@xxxxxxxxxxxxxx> wrote:
> >>
> >>> On 17/2/24 00:28, Jonathan Cameron wrote:
> >>>> On Mon, 12 Feb 2024 13:20:09 +0200
> >>>> Matti Vaittinen <mazziesaccount@xxxxxxxxx> wrote:
> >>>>> The loop based 64bit division may run for a long time when dividend
> >>>>> is a
> >>>>> lot bigger than the divider. Replace the division loop by the
> >>>>> div64_u64() which implementation may be significantly faster.
> >>>>>
> >>>>> Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
> >>>>> Fixes: 38416c28e168 ("iio: light: Add gain-time-scale helpers")
> >>>>>
> >>>>> ---
>
>
> > As I understand that you have already applied this patch but still,
> >
> > Tested-by: Subhajit Ghosh <subhajit.ghosh@xxxxxxxxxxxxxx>
>
> Thank you Subhajit! Your effort is _very much_ appreciated! :)
I had to rebase the tree anyway to squash an unrelated issue, so
I added the tag whilst doing so.

Thanks,

Jonathan

>
> Yours,
> -- Matti
>