Re: [PATCH 2/2] afs: Increase buffer size in afs_update_volume_status()

From: Matthew Wilcox
Date: Mon Feb 19 2024 - 11:54:49 EST


On Mon, Feb 19, 2024 at 02:39:03PM +0000, David Howells wrote:
> From: Daniil Dulov <d.dulov@xxxxxxxxxx>
>
> The max length of volume->vid value is 20 characters.
> So increase idbuf[] size up to 24 to avoid overflow.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> [DH: Actually, it's 20 + NUL, so increase it to 24 and use snprintf()]
>
> Fixes: d2ddc776a458 ("afs: Overhaul volume and server record caching and fileserver rotation")
> Signed-off-by: Daniil Dulov <d.dulov@xxxxxxxxxx>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> Link: https://lore.kernel.org/r/20240211150442.3416-1-d.dulov@xxxxxxxxxx/ # v1
> Link: https://lore.kernel.org/r/20240212083347.10742-1-d.dulov@xxxxxxxxxx/ # v2

Tag it for stable?