Re: [PATCH v2 2/2] platform/x86: thinkpad_acpi: Fix to correct wrong temp reporting on some ThinkPads

From: Ilpo Järvinen
Date: Mon Feb 19 2024 - 06:45:03 EST


On Thu, 15 Feb 2024, Vishnu Sankar wrote:

> Added non-standard thermal register's support for some ThinkPads.
>
> Some of the Thinkpads use a non-standard ECFW which has different
> thermal register addresses. This is a fix to correct the wrong temperature
> reporting on those systems.
>
> Tested on Lenovo ThinkPad L13 Yoga Gen2.
>
> Suggested-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx>
> Signed-off-by: Vishnu Sankar <vishnuocv@xxxxxxxxx>

> @@ -6290,6 +6332,8 @@ static int thermal_get_sensors(struct ibm_thermal_sensors_struct *s)
>
> if (thermal_read_mode == TPACPI_THERMAL_TPEC_16)
> n = 16;
> + else if (thermal_read_mode == TPACPI_THERMAL_TPEC_12)
> + n = 12;
>
> for (i = 0 ; i < n; i++) {
> res = thermal_get_sensor(i, &s->temp[i]);

Thanks. Both patches now applied. I did some further cleanups into the
first patch (which I had requested you to do :-().

This 2nd patch didn't apply cleanly on top of for-next but I handled the
conflict for you this time, in future, please try to base your work on top
of for-next branch.


--
i.