Re: [PATCH 2/2] interconnect: qcom: Add SM7150 driver support

[Konrad Dybcio]

On 18.02.2024 19:32, Danila Tikhonov wrote:
> Add a driver that handles the different NoCs found on SM7150, based on the
> downstream dtb.
> 
> Signed-off-by: Danila Tikhonov <danila@xxxxxxxxxxx>
> ---

Looks rather good, just 3 minor things:


> +
> +static const struct of_device_id qnoc_of_match[] = {
> +	{ .compatible = "qcom,sm7150-aggre1-noc",
> +	  .data = &sm7150_aggre1_noc},

Please unwrap these and add a space before the closing curly bracket

> +	{ .compatible = "qcom,sm7150-aggre2-noc",
> +	  .data = &sm7150_aggre2_noc},
> +	{ .compatible = "qcom,sm7150-camnoc-virt",
> +	  .data = &sm7150_camnoc_virt},
> +	{ .compatible = "qcom,sm7150-compute-noc",
> +	  .data = &sm7150_compute_noc},
> +	{ .compatible = "qcom,sm7150-config-noc",
> +	  .data = &sm7150_config_noc},
> +	{ .compatible = "qcom,sm7150-dc-noc",
> +	  .data = &sm7150_dc_noc},
> +	{ .compatible = "qcom,sm7150-gem-noc",
> +	  .data = &sm7150_gem_noc},
> +	{ .compatible = "qcom,sm7150-mc-virt",
> +	  .data = &sm7150_mc_virt},
> +	{ .compatible = "qcom,sm7150-mmss-noc",
> +	  .data = &sm7150_mmss_noc},
> +	{ .compatible = "qcom,sm7150-system-noc",
> +	  .data = &sm7150_system_noc},
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, qnoc_of_match);
> +
> +static struct platform_driver qnoc_driver = {
> +	.probe = qcom_icc_rpmh_probe,
> +	.remove_new = qcom_icc_rpmh_remove,
> +	.driver = {
> +		.name = "qnoc-sm7150",
> +		.of_match_table = qnoc_of_match,
> +		.sync_state = icc_sync_state,
> +	},
> +};
> +module_platform_driver(qnoc_driver);

This is most certainly a bad choice, but at the same time it doesn't
matter for now.. It's going to be badly delayed anyway, I have some
fixes in the pipeline. Please change it to core_initcall (which may make
your boot slower as of torvalds/master, counter-intuitively.. but I will
surely forget to update this otherwise)

[...]

> +
> +MODULE_DESCRIPTION("Qualcomm SM7150 NoC driver");
> +MODULE_LICENSE("GPL");
> diff --git a/drivers/interconnect/qcom/sm7150.h b/drivers/interconnect/qcom/sm7150.h
> new file mode 100644
> index 000000000000..e00a9b0c1279
> --- /dev/null
> +++ b/drivers/interconnect/qcom/sm7150.h
> @@ -0,0 +1,140 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */

GPL2+BSD3?

Konrad