Re: [PATCH v4 2/4] pwm: dwc: drop redundant error check

[Thorsten Scherer]

Hello,

On Mon, Feb 19, 2024 at 08:11:01AM +0100, Thorsten Scherer wrote:
> Hello,
> 
> On Mon, Feb 19, 2024 at 09:08:33AM +0530, Raag Jadav wrote:
> > pcim_iomap_table() fails only if pcim_iomap_regions() fails. No need to
> > check for failure if the latter is already successful.
> > 
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Signed-off-by: Raag Jadav <raag.jadav@xxxxxxxxx>
> > Tested-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
> > ---
> >  drivers/pwm/pwm-dwc.c | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> > 
> > diff --git a/drivers/pwm/pwm-dwc.c b/drivers/pwm/pwm-dwc.c
> > index c0e586688e57..7dbb72c80ef5 100644
> > --- a/drivers/pwm/pwm-dwc.c
> > +++ b/drivers/pwm/pwm-dwc.c
> > @@ -51,11 +51,8 @@ static int dwc_pwm_probe(struct pci_dev *pci, const struct pci_device_id *id)
> >  		return ret;
> >  	}
> >  
> > +	/* No need to check for failure, pcim_iomap_regions() does it for us. */
> 
> IMHO this comment could be omitted.

I somehow overlooked the discussion in the v2.  Please ignore my
previous mail.

> >  	dwc->base = pcim_iomap_table(pci)[0];
> > -	if (!dwc->base) {
> > -		dev_err(dev, "Base address missing\n");
> > -		return -ENOMEM;
> > -	}
> >  
> >  	ret = devm_pwmchip_add(dev, chip);
> >  	if (ret)
> > -- 
> > 2.35.3
> > 
> > 
> 
> Best regards
> Thorsten

Best regards
Thorsten