Re: [PATCH v3 0/3] Fix double allocation in swiotlb_alloc()

From: Christoph Hellwig
Date: Mon Feb 19 2024 - 01:35:43 EST


Robin and Petr, does this looks good to you now?

On Mon, Feb 05, 2024 at 07:01:24PM +0000, Will Deacon wrote:
> Hi all,
>
> This is version three of the patches I posted recently:
>
> v1: https://lore.kernel.org/r/20240126151956.10014-1-will@xxxxxxxxxx
> v2: https://lore.kernel.org/r/20240131122543.14791-1-will@xxxxxxxxxx
>
> Thanks to Robin for the comments on the most recent version.
>
> Changes since v2 include:
>
> - Restore missing 'continue' statement that got accidentally dropped
> while addressing the initial round of review feedback.
>
> - Reword the commit message in patch #1
>
> - Add a Fixes: tag to the last patch
>
> Cheers,
>
> Will
>
> Cc: iommu@xxxxxxxxxxxxxxx
> Cc: Christoph Hellwig <hch@xxxxxx>
> Cc: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> Cc: Robin Murphy <robin.murphy@xxxxxxx>
> Cc: Petr Tesarik <petr.tesarik1@xxxxxxxxxxxxxxxxxxx>
> Cc: Dexuan Cui <decui@xxxxxxxxxxxxx>
>
> --->8
>
> Will Deacon (3):
> swiotlb: Fix double-allocation of slots due to broken alignment
> handling
> swiotlb: Enforce page alignment in swiotlb_alloc()
> swiotlb: Honour dma_alloc_coherent() alignment in swiotlb_alloc()
>
> kernel/dma/swiotlb.c | 38 ++++++++++++++++++++++++--------------
> 1 file changed, 24 insertions(+), 14 deletions(-)
>
> --
> 2.43.0.594.gd9cf4e227d-goog
---end quoted text---