Re: [PATCH v18 2/3] vfio/pci: rename and export range_intersect_range
From: Ankit Agrawal
Date: Sun Feb 18 2024 - 22:49:43 EST
>> +
>> +/**
>> + * vfio_pci_core_range_intersect_range() - Determine overlap between a buffer
>> + * and register offset ranges.
>> + * @buf_start: start offset of the buffer
>> + * @buf_cnt: number of buffer bytes.
>
> You could drop the '.' at the end to be consistent with the other.
Ok, will make it consistent.
>> +bool vfio_pci_core_range_intersect_range(loff_t buf_start, size_t buf_cnt,
>> + loff_t reg_start, size_t reg_cnt,
>> + loff_t *buf_offset,
>> + size_t *intersect_count,
>> + size_t *register_offset);
>> #define VFIO_IOWRITE_DECLATION(size) \
>> int vfio_pci_core_iowrite##size(struct vfio_pci_core_device *vdev, \
>> bool test_mem, u##size val, void __iomem *io);
>
> Reviewed-by: Yishai Hadas <yishaih@xxxxxxxxxx>
Thanks