Re: [PATCH] media: rkisp1: Allow higher input resolution

[Adam Ford]

On Sun, Feb 18, 2024 at 3:02 PM Ondřej Jirman <megi@xxxxxx> wrote:
>
> On Sun, Feb 18, 2024 at 10:59:08PM +0200, Laurent Pinchart wrote:
> > Hi Ondrej,
> >
> > (CC'ing Paul and Umang)
> >
> > Thank you for the patch.
> >
> > On Sat, Feb 17, 2024 at 07:51:58PM +0100, Ondřej Jirman wrote:
> > > From: Ondrej Jirman <megi@xxxxxx>
> > >
> > > In BSP driver, it is allowed, and it works in practice. Tested on
> > > Pinephone Pro/RK3399 with IMX258 at full res.
> >
> > Paul, Umang, do I recall correctly that you have a similar change ?
> > Could you review and test this (especially on the i.MX8MP) ?
>
> It's also a limit from the datasheet, so the change should not be that
> controversial:
>
>   https://megous.com/dl/tmp/d2b333043ecebaf3.png
>
> (so that it doesn't sound like I just copied the BSP values)
>

>From what I see in the i.MX8M Plus reference manual, it has a max
resolution of 4096x3072, so it might be necessary to move this off
from a #define into a structure that varies by product family.

adam
> regards,
>         o.
>
> > > Signed-off-by: Ondrej Jirman <megi@xxxxxx>
> > > ---
> > >  drivers/media/platform/rockchip/rkisp1/rkisp1-common.h | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
> > > index 4b6b28c05b89..74098ddbeeb3 100644
> > > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
> > > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
> > > @@ -33,8 +33,8 @@ struct dentry;
> > >  #define RKISP1_ISP_SD_SINK                 BIT(1)
> > >
> > >  /* min and max values for the widths and heights of the entities */
> > > -#define RKISP1_ISP_MAX_WIDTH                       4032
> > > -#define RKISP1_ISP_MAX_HEIGHT                      3024
> > > +#define RKISP1_ISP_MAX_WIDTH                       4416
> > > +#define RKISP1_ISP_MAX_HEIGHT                      3312
> > >  #define RKISP1_ISP_MIN_WIDTH                       32
> > >  #define RKISP1_ISP_MIN_HEIGHT                      32
> > >
> >
> > --
> > Regards,
> >
> > Laurent Pinchart
>