Re: [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm SM7150 DT bindings

[Danila Tikhonov]

I removed compatible duplicates from qcom,rpmh-common.yaml. No more
warnings. I also followed your advice regarding the name of the child
node. Maybe something else?

---
Best wishes
Danila

On 2/18/24 21:52, Krzysztof Kozlowski wrote:
> On 18/02/2024 19:32, Danila Tikhonov wrote:
> > The Qualcomm SM7150 platform has several bus fabrics that could be
> > controlled and tuned dynamically according to the bandwidth demand.
> >
> > Signed-off-by: Danila Tikhonov <danila@xxxxxxxxxxx>
> > ---
> >   .../interconnect/qcom,sm7150-rpmh.yaml        |  88 ++++++++++
> >   .../interconnect/qcom,sm7150-rpmh.h           | 150 ++++++++++++++++++
> >   2 files changed, 238 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sm7150-rpmh.yaml
> >   create mode 100644 include/dt-bindings/interconnect/qcom,sm7150-rpmh.h
> >
> > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sm7150-rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sm7150-rpmh.yaml
> > new file mode 100644
> > index 000000000000..604822ed4adc
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/interconnect/qcom,sm7150-rpmh.yaml
> > @@ -0,0 +1,88 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/interconnect/qcom,sm7150-rpmh.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm RPMh Network-On-Chip Interconnect on SM7150
> > +
> > +maintainers:
> > +  - Danila Tikhonov <danila@xxxxxxxxxxx>
> > +
> > +description: |
> > +  RPMh interconnect providers support system bandwidth requirements through
> > +  RPMh hardware accelerators known as Bus Clock Manager (BCM).
> > +
> > +  See also:: include/dt-bindings/interconnect/qcom,sm7150-rpmh.h
> > +
> > +allOf:
> > +  - $ref: qcom,rpmh-common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - qcom,sm7150-aggre1-noc
> > +      - qcom,sm7150-aggre2-noc
> > +      - qcom,sm7150-compute-noc
> > +      - qcom,sm7150-config-noc
> > +      - qcom,sm7150-dc-noc
> > +      - qcom,sm7150-gem-noc
> > +      - qcom,sm7150-mc-virt
> > +      - qcom,sm7150-mmss-noc
> > +      - qcom,sm7150-system-noc
> I don't see how you resolved the warning we talked about on IRC.
>
> Best regards,
> Krzysztof