Re: [PATCH net-next v3 1/8] net: usb: r8152: Use linkmode helpers for EEE

From: Andrew Lunn
Date: Sat Feb 17 2024 - 13:41:34 EST


On Sat, Feb 17, 2024 at 12:08:22PM -0600, Andrew Lunn wrote:
> Make use of the existing linkmode helpers for converting PHY EEE
> register values into links modes, now that ethtool_keee uses link
> modes, rather than u32 values.
>
> Rework determining if EEE is active to make is similar as to how
> phylib decides, and make use of a phylib helper to validate if EEE is
> valid in for the current link mode. This then requires that PHYLIB is
> selected.

I started on the next step to remove the _u32 values. And found i
missed a conversion in this file.

v4 tomorrow.


Andrew

---
pw-bot: cr