Re: [PATCH v4 2/8] clk: qcom: ipq5332: enable few nssnoc clocks in driver probe

[Kathiravan Thirumoorthy]

<snip>

> > Reason being, to access the NSSCC clocks, these GCC clocks
> > (gcc_snoc_nssnoc_clk, gcc_snoc_nssnoc_1_clk, gcc_nssnoc_nsscc_clk)
> > should be turned ON. But CCF disables these clocks as well due to the
> > lack of consumer.
>
> This means that NSSCC is also a consumer of those clocks. Please fix
> both DT and nsscc driver to handle NSSNOC clocks.


Thanks Dmitry. I shall include these clocks in the NSSCC DT node and 
enable the same in the NSSCC driver probe.

> > > Once you have actual drivers, this should solve itself, the drivers
> > > will consume the clocks.
> >
> >
> > Given that, NSSCC is being built as module, there is no issue in booting
> > the kernel. But if you do insmod of the nsscc-ipq5332.ko, system will
> > reset.
> >
> > Without the networking drivers, there is no need to install this module.
> > And as you stated, once the drivers are available, there will be no issues.
> >
> > So can I explain the shortcomings of installing this module without the
> > networking drivers in cover letter and drop this patch all together?
>
> No. Using allyesconfig or allmodconfig and installing the full modules
> set should work.


Okay, Got it. Thanks for the information.

<snip>