Re: [PATCH 2/2] riscv: dts: sophgo: cv18xx: add top misc system controller

[Jisheng Zhang]

On Wed, Feb 14, 2024 at 09:35:55AM +0800, Inochi Amaoto wrote:
> Add top misc system controller dt node for CV18XX/SG200x.

it's better to delay this patch until users is seen.

> 
> Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxxxx>
> ---
>  arch/riscv/boot/dts/sophgo/cv18xx.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> index 2d6f4a4b1e58..dbf018e99c48 100644
> --- a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> @@ -53,6 +53,14 @@ soc {
>  		dma-noncoherent;
>  		ranges;
> 
> +		topctrl: syscon@3000000 {

"sysctrl" is better, the TRM name this as system controller.

> +			compatible = "sophgo,cv1800-top-syscon",
> +				     "syscon", "simple-mfd";
> +			reg = <0x03000000 0x1000>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +		};
> +
>  		gpio0: gpio@3020000 {
>  			compatible = "snps,dw-apb-gpio";
>  			reg = <0x3020000 0x1000>;
> --
> 2.43.1
>