Re: [PATCH 2/2] dt-binding: watchdog: arm,sp805: document the reset signal

From: Krzysztof Kozlowski
Date: Sat Feb 17 2024 - 03:44:10 EST


On 17/02/2024 05:40, Yang Xiwen via B4 Relay wrote:
> From: Yang Xiwen <forbidden405@xxxxxxxxxxx>
>
> The reset signal needs to be deasserted before operation of sp805
> module. Document in the binding.
>

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.

It's dt-bindings

> Signed-off-by: Yang Xiwen <forbidden405@xxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/watchdog/arm,sp805.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml b/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml
> index 7aea255b301b..6d4f63f23f1a 100644
> --- a/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml
> @@ -50,6 +50,11 @@ properties:
> - const: wdog_clk
> - const: apb_pclk
>
> + resets:
> + maxItems: 1
> + description: |

Do not need '|' unless you need to preserve formatting.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof