Re: [RFC PATCH 3/8] mm: Use get_unmapped_area_vmflags()

[Edgecombe, Rick P]

On Fri, 2024-02-16 at 14:56 +0200, Kirill A. Shutemov wrote:
> > +unsigned long
> > +get_unmapped_area(struct file *file, unsigned long addr, unsigned
> > long len,
> > +               unsigned long pgoff, unsigned long flags)
> > +{
> > +       return __get_unmapped_area(file, addr, len, pgoff, flags,
> > 0);
> > +}
> >   EXPORT_SYMBOL(get_unmapped_area);
> 
> Any reason it is not a static inline function in the header file?

get_unmapped_area() doesn't seem to be referenced from any modules. I
don't think it needs to be exported actually. Maybe it used to be?

It could be a static inline it seems. Why are you thinking it would be
better?

I think maybe get_unmapped_area() should stay as is, static-inline
wise, but remove the export, and the newly added __get_unmapped_area()
should be made static. Does it sound reasonable?