Re: [PATCH v2 1/6] mm/migrate: introduce migrate_pfn_to_folio()

From: Sidhartha Kumar
Date: Fri Feb 16 2024 - 17:04:32 EST


On 2/16/24 1:50 PM, Matthew Wilcox wrote:
On Fri, Feb 16, 2024 at 01:13:15PM -0800, Sidhartha Kumar wrote:
+static inline struct folio *migrate_pfn_to_folio(unsigned long mpfn)
+{
+ return page_folio(migrate_pfn_to_page(mpfn));

umm, no.

struct page *page = migrate_pfn_to_page(mpfn);
if (page)
return page_folio(page);
return NULL;

Thanks, I overlooked checking for NULL before converting the page to a folio. I'll make this change for v3.