[PATCH v2 4/6] mm/migrate_device: convert __migrate_device_pages() to folios

From: Sidhartha Kumar
Date: Fri Feb 16 2024 - 16:29:29 EST


Use migrate_pfn_to_folio() so we can work with folios directly in
__migrate_device_pages().

Signed-off-by: Sidhartha Kumar <sidhartha.kumar@xxxxxxxxxx>
---
mm/migrate_device.c | 36 +++++++++++++++---------------------
1 file changed, 15 insertions(+), 21 deletions(-)

diff --git a/mm/migrate_device.c b/mm/migrate_device.c
index 81623f2d72c2b..d9633c7b1d21b 100644
--- a/mm/migrate_device.c
+++ b/mm/migrate_device.c
@@ -687,17 +687,17 @@ static void __migrate_device_pages(unsigned long *src_pfns,
bool notified = false;

for (i = 0; i < npages; i++) {
- struct page *newpage = migrate_pfn_to_page(dst_pfns[i]);
- struct page *page = migrate_pfn_to_page(src_pfns[i]);
+ struct folio *dst = migrate_pfn_to_folio(dst_pfns[i]);
+ struct folio *src = migrate_pfn_to_folio(src_pfns[i]);
struct address_space *mapping;
int r;

- if (!newpage) {
+ if (!dst) {
src_pfns[i] &= ~MIGRATE_PFN_MIGRATE;
continue;
}

- if (!page) {
+ if (!src) {
unsigned long addr;

if (!(src_pfns[i] & MIGRATE_PFN_MIGRATE))
@@ -719,33 +719,29 @@ static void __migrate_device_pages(unsigned long *src_pfns,
migrate->pgmap_owner);
mmu_notifier_invalidate_range_start(&range);
}
- migrate_vma_insert_page(migrate, addr, newpage,
+ migrate_vma_insert_page(migrate, addr, &dst->page,
&src_pfns[i]);
continue;
}

- mapping = page_mapping(page);
+ mapping = folio_mapping(src);

- if (is_device_private_page(newpage) ||
- is_device_coherent_page(newpage)) {
+ if (folio_is_device_private(dst) ||
+ folio_is_device_coherent(dst)) {
if (mapping) {
- struct folio *folio;
-
- folio = page_folio(page);
-
/*
* For now only support anonymous memory migrating to
* device private or coherent memory.
*
* Try to get rid of swap cache if possible.
*/
- if (!folio_test_anon(folio) ||
- !folio_free_swap(folio)) {
+ if (!folio_test_anon(src) ||
+ !folio_free_swap(src)) {
src_pfns[i] &= ~MIGRATE_PFN_MIGRATE;
continue;
}
}
- } else if (is_zone_device_page(newpage)) {
+ } else if (folio_is_zone_device(dst)) {
/*
* Other types of ZONE_DEVICE page are not supported.
*/
@@ -753,13 +749,11 @@ static void __migrate_device_pages(unsigned long *src_pfns,
continue;
}

- if (migrate && migrate->fault_page == page)
- r = migrate_folio_extra(mapping, page_folio(newpage),
- page_folio(page),
- MIGRATE_SYNC_NO_COPY, 1);
+ if (migrate && migrate->fault_page == &src->page)
+ r = migrate_folio_extra(mapping, dst, src,
+ MIGRATE_SYNC_NO_COPY, 1);
else
- r = migrate_folio(mapping, page_folio(newpage),
- page_folio(page), MIGRATE_SYNC_NO_COPY);
+ r = migrate_folio(mapping, dst, src, MIGRATE_SYNC_NO_COPY);
if (r != MIGRATEPAGE_SUCCESS)
src_pfns[i] &= ~MIGRATE_PFN_MIGRATE;
}
--
2.42.0