Re: [PATCH 2/6] net: hisi_femac: remove unused compatible strings

From: Yang Xiwen
Date: Fri Feb 16 2024 - 15:09:49 EST


On 2/17/2024 4:05 AM, Conor Dooley wrote:
On Fri, Feb 16, 2024 at 02:01:08PM +0100, Andrew Lunn wrote:
For me, it's a bit lucky to find a (partially) working driver in mainline.
It'll take me even more time if no mainline driver is available. In fact, i
wrote the driver for mainline u-boot from scratch and it has been merged. So
it's good to have this binding accepted unmodified, or i'll have to modify
u-boot side driver code to keep them sync.
Sorry, but that is not how it works. If during review we decided it
needs to be modified, you will need to modify it.

I would suggest you first mainstream bindings to the kernel, because
it has active DT maintainers how really care about bindings. Then get
is merged to u-boot.
Just to note, the U-Boot folk are currently working on a model where
they will be importing the kernel's dts files directly into their tree
along with the bindings. I think they're adding dtbs_check too.
Although that will be opt-in per board, it does point to an increased
desire for compliance there too, which is great.

Of course. I'll sync this stuff back to u-boot once this gets accepted and merged. I begin working from u-boot simply because the Driver Model of U-Boot is much simpler than Linux's. I wrote the driver for U-Boot first to figure out how the hardware is working, then port it to Linux.

--
Regards,
Yang Xiwen