Re: [PATCH] arm64: dts: qcom: ipq6018: add #power-domain-cells for gcc node

[Bjorn Andersson]

On Thu, Jan 04, 2024 at 11:53:46AM +0200, Dmitry Baryshkov wrote:
> On Thu, 4 Jan 2024 at 10:06, Fenglin Wu via B4 Relay
> <devnull+quic_fenglinw.quicinc.com@xxxxxxxxxx> wrote:
> >
> > From: Fenglin Wu <quic_fenglinw@xxxxxxxxxxx>
> >
> > Property '#power-domain-cells' is required as per defined in qcom,gcc.yaml
> > so add it for ipq6018 gcc device node to eliminate following warning in
> > dtbs_check:
> >
> > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dtb: gcc@1800000:
> >         '#power-domain-cells' is a required property
> > from schema $id: http://devicetree.org/schemas/clock/qcom,gcc-ipq6018.yaml#
> 
> But ipq6018 doesn't implement GDSC support. So for the sake of fixing
> the warning you are adding a bogus property.
> 

The platform does indeed have two USB GDSCs, which you can see being
referred to in gcc_ipq6018_probe().

But while this patch removes a warning, I think the proper solution
would be to actually describe those GDSCs in the DeviceTree as well.
Unfortunately this would imply the need to actually implement them in
Linux as well.


Alternatively, there exist a reason for not actually change the state of
these GDSCs at runtime - i.e. the gcc driver is doing the right thing.
But if so, this patch would be wrong...

Regards,
Bjorn

> >
> > Signed-off-by: Fenglin Wu <quic_fenglinw@xxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/ipq6018.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> > index 39cd6b76b4c1..54914912d610 100644
> > --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> > @@ -386,6 +386,7 @@ gcc: gcc@1800000 {
> >                         reg = <0x0 0x01800000 0x0 0x80000>;
> >                         clocks = <&xo>, <&sleep_clk>;
> >                         clock-names = "xo", "sleep_clk";
> > +                       #power-domain-cells = <1>;
> >                         #clock-cells = <1>;
> >                         #reset-cells = <1>;
> >                 };
> >
> > ---
> > base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240
> > change-id: 20240103-gcc-docs-update-fa604579e468
> >
> > Best regards,
> > --
> > Fenglin Wu <quic_fenglinw@xxxxxxxxxxx>
> >
> >
> 
> 
> -- 
> With best wishes
> Dmitry