Re: [PATCH v2 4/7] mmc: sdhci_am654: Fix itapdly/otapdly array type

[Adrian Hunter]

On 7/02/24 03:15, Judith Mendez wrote:
> While integer type works, the otap_del_sel and itap_del_sel
> arrays are manipulated as u32, so change array types to u32.

If it doesn't make any practical difference, then it is not
generally considered a "fix", at least according to stable
kernel rules, so Fixes tags are probably not warranted here.

> 
> Fixes: 8ee5fc0e0b3b ("mmc: sdhci_am654: Update OTAPDLY writes")
> Fixes: a0a62497f6aa ("mmc: sdhci_am654: Add support for input tap delay")
> Signed-off-by: Judith Mendez <jm@xxxxxx>
> ---
>  drivers/mmc/host/sdhci_am654.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
> index 935f581c05d8..35ba7d921690 100644
> --- a/drivers/mmc/host/sdhci_am654.c
> +++ b/drivers/mmc/host/sdhci_am654.c
> @@ -141,8 +141,8 @@ static const struct timing_data td[] = {
>  
>  struct sdhci_am654_data {
>  	struct regmap *base;
> -	int otap_del_sel[ARRAY_SIZE(td)];
> -	int itap_del_sel[ARRAY_SIZE(td)];
> +	u32 otap_del_sel[ARRAY_SIZE(td)];
> +	u32 itap_del_sel[ARRAY_SIZE(td)];
>  	u32 itap_del_ena[ARRAY_SIZE(td)];
>  	int clkbuf_sel;
>  	int trm_icp;