Re: [PATCH v4 2/2] iio: adc: ti-ads1298: Add driver

[Mike Looijmans]

On 16-02-2024 14:38, Jonathan Cameron wrote:
> On Wed, 14 Feb 2024 07:37:36 +0100
> Mike Looijmans <mike.looijmans@xxxxxxxx> wrote:
>
> > Skeleton driver for the TI ADS1298 medical ADC. This device is
> > typically used for ECG and similar measurements. Supports data
> > acquisition at configurable scale and sampling frequency.
> >
> > Signed-off-by: Mike Looijmans <mike.looijmans@xxxxxxxx>
> Hi Mike,
>
> One final thing noticed on a (hopefully) last read through.
>
> /sys/bus/iio:device0/name is going to read ads1298 whichever
> chip is detected.
>
> Would be more useful to users if it identified the actual
> part given that is easily read from the ID register.

Implemented it like that, the "name" now reflects the chip's information.

While at it, I also made the probe fail on invalid ID (tested by probing 
an empty SPI bus)

And also pass the channel count into the "num_channels" member, and 
adapted the SPI transaction, which should support the devices with 4 or 
6 channels better.

I'll post a v5 soon, bit of testing first...

--
Mike Looijmans
System Expert

TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@xxxxxxxx
W: www.topic.nl