Re: [PATCH 2/2] kobject: reduce uevent_sock_mutex scope

[Christian Brauner]

On Wed, Feb 14, 2024 at 08:48:29AM +0000, Eric Dumazet wrote:
> This is a followup of commit a3498436b3a0 ("netns: restrict uevents")
> 
> - uevent_sock_mutex no longer protects uevent_seqnum thanks
>   to prior patch in the series.
> 
> - uevent_net_broadcast() can run without holding uevent_sock_mutex.
> 
> - Instead of grabbing uevent_sock_mutex before calling
>   kobject_uevent_net_broadcast(), we can move the
>   mutex_lock(&uevent_sock_mutex) to the place we iterate over
>   uevent_sock_list : uevent_net_broadcast_untagged().
> 
> After this patch, typical netdevice creations and destructions
> calling uevent_net_broadcast_tagged() no longer need to acquire
> uevent_sock_mutex.
> 
> Signed-off-by: Eric Dumazet <edumazet@xxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Christian Brauner <brauner@xxxxxxxxxx>
> ---

Very nice,
Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx>