Re: [RFC PATCH v1 0/5] VT: Add ability to get font requirements

From: Alexey Gladkov
Date: Fri Feb 16 2024 - 09:41:45 EST


On Fri, Feb 16, 2024 at 02:45:22PM +0100, Samuel Thibault wrote:
> Alexey Gladkov, le ven. 16 févr. 2024 14:26:38 +0100, a ecrit:
> > On Fri, Feb 16, 2024 at 08:21:38AM +0100, Jiri Slaby wrote:
> > > On 15. 02. 24, 16:37, Alexey Gladkov wrote:
> > > > We now have KD_FONT_OP_SET_TALL, but in fact such large fonts cannot be
> > > > loaded. No console driver supports tall fonts.
> > >
> > > I thought fbcon can, no? If not, we should likely remove all the
> > > KD_FONT_OP_SET_TALL checks here and there.
> >
> > I thought so too until kbd users started trying to use such fonts. A month
> > after adding KD_FONT_OP_SET_TALL, support for large fonts was turned off
> > in fbcon:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=2b09d5d364986f724f17001ccfe4126b9b43a0be
> >
> > But I don't think we need to remove KD_FONT_OP_SET_TALL completely. Maybe
> > support for large fonts can be fixed.
>
> Some users *need* it to be fixed, because they need large fonts to be
> able to read their screen.

I totally understand that. That's why I don't think it's necessary to
remove or block SET_TALL. And that's also why I added you to the thread.

--
Rgrds, legion