Re: [PATCH net-next 09/15] net/smc: introduce loopback-ism statistics attributes

From: Wenjia Zhang
Date: Fri Feb 16 2024 - 09:24:31 EST




On 11.01.24 13:00, Wen Gu wrote:
This introduces some statistics attributes of loopback-ism. They can be
read from /sys/devices/virtual/smc/loopback-ism/{xfer_tytes|dmbs_cnt}.

Signed-off-by: Wen Gu <guwen@xxxxxxxxxxxxxxxxx>
---
net/smc/smc_loopback.c | 74 ++++++++++++++++++++++++++++++++++++++++++
net/smc/smc_loopback.h | 22 +++++++++++++
2 files changed, 96 insertions(+)


I've read the comments from Jiri and your answer. I can understand your thought. However, from the perspective of the end user, it makes more sense to integetrate the stats info into 'smcd stats'. Otherwise, it would make users confused to find out with which tool to check which statisic infornation. Sure, some improvement of the smc-tools is also needed