Re: [PATCH v4 2/2] phy: qcom: edp: Add set_mode op for configuring eDP/DP submode

[Konrad Dybcio]

On 16.02.2024 14:02, Abel Vesa wrote:
> Future platforms should not use different compatibles to differentiate
> between eDP and DP mode. Instead, they should use a single compatible as
> the IP block is the same. It will be the job of the controller to set the
> submode of the PHY accordingly.
> 
> The existing platforms will remain with separate compatibles for each
> mode.
> 
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> ---

[...]

>  
> +static int qcom_edp_phy_set_mode(struct phy *phy, enum phy_mode mode, int submode)
> +{
> +	struct qcom_edp *edp = phy_get_drvdata(phy);
> +
> +	if (mode != PHY_MODE_DP)
> +		return -EINVAL;
> +
> +	edp->is_edp = submode == PHY_SUBMODE_EDP ? true : false;

it's bool-converted even without the ternary operator

Konrad