Re: [PATCH 4/6] dt-bindings: net: add hisilicon-femac

From: Krzysztof Kozlowski
Date: Fri Feb 16 2024 - 04:42:04 EST


On 16/02/2024 10:36, Yang Xiwen wrote:
>>
>>> + maxItems: 2
>>> +
>>> + reset-names:
>>> + items:
>>> + - const: mac
>>> + - const: phy
>>> +
>>> + hisilicon,phy-reset-delays-us:
>>> + minItems: 3
>>> + maxItems: 3
>>> + description: |
>>> + The 1st cell is reset pre-delay in micro seconds.
>>> + The 2nd cell is reset pulse in micro seconds.
>>> + The 3rd cell is reset post-delay in micro seconds.
>> items:
>> - description:
>>
>> Anyway, isn't this property of the phy?
> It ought to be. But it seems a bit hard to implement it like this.

Why? You have phy node, so phy should know what to do.



Best regards,
Krzysztof