Re: [PATCH v2 1/1] serial: 8250_of: Drop quirk fot NPCM from 8250_port

[Ilpo Järvinen]

On Thu, 15 Feb 2024, Andy Shevchenko wrote:

> On Thu, Feb 15, 2024 at 06:40:15PM +0200, Ilpo Järvinen wrote:
> > On Thu, 15 Feb 2024, Andy Shevchenko wrote:
> 
> ...
> 
> > > +	/*
> > > +	 * Nuvoton calls the scratch register 'UART_TOR' (timeout
> > > +	 * register). Enable it, and set TIOC (timeout interrupt
> > > +	 * comparator) to be 0x20 for correct operation.
> > > +	 */
> > > +	serial_port_out(port, UART_NPCM_TOR, UART_NPCM_TOIE | 0x20);
> > > +
> > > +	return serial8250_do_startup(port);
> > 
> > I know this matches how it is currently done\
> 
> Exactly, I haven't changed the workflow.
> Does it mean you are okay with the change?

Mostly. Another thing I was let bit unsure if it's okay to move that 
serial_port_out() outside of RPM get/put that is inside 
serial8250_do_startup().

> > but I wonder if TOIE should not be enabled until ->setup_irq()
> > has been called.
> 
> No idea, this will need an extensive test on the hardware and should
> be done separately anyway. I have no HW to test this.

Okay.

-- 
 i.