RE: [PATCH 1/3] drm/radeon: Use RMW accessors for changing LNKCTL2

[Ilpo Järvinen]

On Thu, 15 Feb 2024, Deucher, Alexander wrote:

> [Public]
> 
> > -----Original Message-----
> > From: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> > Sent: Thursday, February 15, 2024 8:32 AM
> > To: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; amd-
> > gfx@xxxxxxxxxxxxxxxxxxxxx; Daniel Vetter <daniel@xxxxxxxx>; David Airlie
> > <airlied@xxxxxxxxx>; Dennis Dalessandro
> > <dennis.dalessandro@xxxxxxxxxxxxxxxxxxxx>; dri-
> > devel@xxxxxxxxxxxxxxxxxxxxx; Jason Gunthorpe <jgg@xxxxxxxx>; Leon
> > Romanovsky <leon@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; linux-
> > rdma@xxxxxxxxxxxxxxx; Pan, Xinhui <Xinhui.Pan@xxxxxxx>; Koenig, Christian
> > <Christian.Koenig@xxxxxxx>
> > Cc: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>; Lukas Wunner
> > <lukas@xxxxxxxxx>
> > Subject: [PATCH 1/3] drm/radeon: Use RMW accessors for changing LNKCTL2
> >
> > Convert open coded RMW accesses for LNKCTL2 to use
> > pcie_capability_clear_and_set_word() which makes its easier to understand
> > what the code tries to do.
> >
> > LNKCTL2 is not really owned by any driver because it is a collection of control
> > bits that PCI core might need to touch. RMW accessors already have support
> > for proper locking for a selected set of registers
> > (LNKCTL2 is not yet among them but likely will be in the future) to avoid losing
> > concurrent updates.
> >
> > Suggested-by: Lukas Wunner <lukas@xxxxxxxxx>
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> 
> The radeon and amdgpu patches are:
> Acked-by: Alex Deucher <alexander.deucher@xxxxxxx>
> 
> Are you looking for me to pick them up or do you want to land them as 
> part of some larger change?  Either way is fine with me. 

Hi,

You please take them, I intentionally took them apart from the BW 
controller series so they can go through the usual trees, not along with 
the BW controller. (I don't expect the BW controller to be accepted during 
this cycle).

-- 
 i.