Re: [PATCH v2 0/2] drm/bridge: tc358767: Fix DRM_BRIDGE_ATTACH_NO_CONNECTOR case

From: Tomi Valkeinen
Date: Fri Feb 16 2024 - 04:10:30 EST


On 15/02/2024 11:03, Alexander Stein wrote:
Hi everyone,

Am Donnerstag, 15. Februar 2024, 09:53:54 CET schrieb Jan Kiszka:
On 11.12.23 09:07, Aradhya Bhatia wrote:
On 06/12/23 17:41, Tomi Valkeinen wrote:
Hi,

On 08/11/2023 14:45, Alexander Stein wrote:
Hi Tomi,

Am Mittwoch, 8. November 2023, 12:27:21 CET schrieb Tomi Valkeinen:
These two patches are needed to make tc358767 work in the
DRM_BRIDGE_ATTACH_NO_CONNECTOR case, at least when using a DP
connector.

I have tested this with TI AM654 EVM with a tc358767 add-on card
connected to a DP monitor.

Just a question regarding the usage of this DSI-DP bridge.
What is the state of the DSI lanes after the DSI host has been
initialized,
but before calling atomic_pre_enable? AFAIK this bridge requires LP-11
on DSI
at any time for accessing the AUX channel.

+ Marek

Marek, Alexander,

A quick grep tells me that you have added devicetree for tc358767 in DSI
to (e)DP mode on other platforms. Could you please test these patches
and report if you find any issue?

Sorry, I can't provide any feedback here. I've yet to setup the DSI-DP
correctly.

Ok. Does anyone have a worry that these patches make the situation worse for the DSI case than it was before? Afaics, if the DSI lanes are not set up early enough by the DSI host, the driver would break with and without these patches.

These do fix the driver for DRM_BRIDGE_ATTACH_NO_CONNECTOR and DPI, so I'd like to merge these unless these cause a regression with the DSI case.

Tomi