Re: [PATCH 2/6] net: hisi_femac: remove unused compatible strings

[Yang Xiwen]

On 2/16/2024 4:26 PM, Krzysztof Kozlowski wrote:
> On 16/02/2024 09:21, Yang Xiwen wrote:
> > On 2/16/2024 3:20 PM, Krzysztof Kozlowski wrote:
> > > On 16/02/2024 00:48, Yang Xiwen via B4 Relay wrote:
> > > > From: Yang Xiwen <forbidden405@xxxxxxxxxxx>
> > > >
> > > > These compatible strings are not found in any mainline dts, remove them.
> > > That's not a real reason. What about all other users?
> > The people who want their devices being supported should post a working
> > dts first. Having found the dts missing is strongly telling me that this
> Considering how poor HiSilicon contributions were - in numbers and
> quality - that's kind of expected. :(
>
>
> > SoC(Hi3516) is orphan and EOL already. I can't even find it in git
> > commit logs. I'll argue that the old binding is simply wrong, and does
> > not describe the hardware properly. Who knows? Could anyone tell me if
> > the driver is still working for Hi3516 or not? I'm very willing to keep
> > the backward compatibility if someone can tell me the effort i paid to
> > maintain the old binding really makes sense. But the only things i found
> > in mainline kernel about Hi3516 is an CRG(clock) driver and this femac
> > driver. And it's been 8 years since last update for this SoC.
> OK, that's fine with me, but please add parts of this explanation to the
> commit msg (SoC is EOL, driver looks buggy and might not even work,
> platform was upstreamed 8 years ago and no maintenance work happened on
> it, thus it looks abandoned etc.).

For me, it's a bit lucky to find a (partially) working driver in 
mainline. It'll take me even more time if no mainline driver is 
available. In fact, i wrote the driver for mainline u-boot from scratch 
and it has been merged. So it's good to have this binding accepted 
unmodified, or i'll have to modify u-boot side driver code to keep them 
sync.

> Best regards,
> Krzysztof

--
Regards,
Yang Xiwen