Re: [EXT] Re: [PATCH v2 0/2] Fix PHY init timeout issues

From: Adrian Hunter
Date: Fri Feb 16 2024 - 03:29:00 EST


On 15/02/24 19:01, Elad Nachman wrote:
>
>
>> -----Original Message-----
>> From: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
>> Sent: Thursday, February 15, 2024 6:51 PM
>> To: Elad Nachman <enachman@xxxxxxxxxxx>
>> Cc: huziji@xxxxxxxxxxx; adrian.hunter@xxxxxxxxx; linux-
>> mmc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>> Subject: [EXT] Re: [PATCH v2 0/2] Fix PHY init timeout issues
>>
>> External Email
>>
>> ----------------------------------------------------------------------
>> On Thu, 15 Feb 2024 at 17:16, Elad Nachman <enachman@xxxxxxxxxxx>
>> wrote:
>>>
>>> From: Elad Nachman <enachman@xxxxxxxxxxx>
>>>
>>> Fix PHY init timeout issues:
>>>
>>> 1. Clock Stability issue causing PHY timeout
>>>
>>> 2. Timeout taking longer than needed on AC5X.
>>> Solve by constantly testing the PHY init bit
>>> until it toggles, but up to 100X timeout factor.
>>>
>>> v2:
>>> 1) convert polling loop to read_poll_timeout()
>>> for both patches.
>>>
>>> Elad Nachman (2):
>>> mmc: xenon: fix PHY init clock stability
>>> mmc: xenon: add timeout for PHY init complete
>>>
>>> drivers/mmc/host/sdhci-xenon-phy.c | 48
>>> ++++++++++++++++++++++++------
>>> 1 file changed, 39 insertions(+), 9 deletions(-)
>>>
>>
>> The series looks good to me. Although, I assume we should tag this for stable
>> kernels too and possibly add a fixes tag?
>
> No problem.

Presumably:

Fixes: 06c8b667ff5b ("mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC")

FWIW:

Acked-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>

>
>>
>> Moreover, it would be nice to get an ack from Hu Ziji.
>
> He does not longer work with Marvell, so this email is invalid, I tried also to send an e-mail manually as well and got:
> huziji@xxxxxxxxxxx
> Remote Server returned '550 5.1.1 RESOLVER.ADR.RecipNotFound; not found'
>
> Could not locate him via google search either.
>
>>
>> Kind regards
>> Uffe