Re: [PATCH v2] mm: document memalloc_noreclaim_save() and memalloc_pin_save()

From: Andrew Morton
Date: Thu Feb 15 2024 - 18:56:16 EST


On Thu, 15 Feb 2024 10:58:28 +0100 Vlastimil Babka <vbabka@xxxxxxx> wrote:
>
> ...
>
> v2: fix issues that Mike pointed out

Cool.

> sending as replacement instead of fixup because I've used the wrong
> address for Kent and it became part of Cc: tag in the mm tree.

akpm has editor ;)

> + * This function marks the beginning of the __GFP_MEMALLOC allocation scope.
> ...
>
> + * This function marks the beginning of the ~__GFP_MOVABLE allocation scope.

pet peeves. We can assume that the reader knows that this is a
function! Perhaps we should teach checkpatch to whine.

Like "the function foo" and "the function foo()" in changelogs.
"foo()" is enough!