Re: [PATCH 2/3] dt-bindings: display: ltk500hd1829: add variant compatible for ltk101b4029w

[Heiko Stübner]

Am Donnerstag, 15. Februar 2024, 18:06:06 CET schrieb Conor Dooley:
> On Thu, Feb 15, 2024 at 10:05:14AM +0100, Heiko Stuebner wrote:
> > From: Heiko Stuebner <heiko.stuebner@xxxxxxxxx>
> > 
> > Add the compatible for the ltk101b4029w panel, that is really similar
> > to the ltk500hd1829.
> 
> Please mention what makes the devices incompatible. "really similar" is
> vague and could be used for a device that was only cosmetically
> different.

ok, I'll modify the paragraph to:

=======
Add the compatible for the ltk101b4029w panel, that has the same
manufacturer, general bringup and supplies but a different dsi-init-
sequence as the ltk500hd1829 .
=======

> With that,
> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> 
> Cheers,
> Conor.
> 
> > 
> > Signed-off-by: Heiko Stuebner <heiko.stuebner@xxxxxxxxx>
> > ---
> >  .../bindings/display/panel/leadtek,ltk500hd1829.yaml          | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml b/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
> > index c5944b4d636c5..d589f16772145 100644
> > --- a/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
> > @@ -14,7 +14,9 @@ allOf:
> >  
> >  properties:
> >    compatible:
> > -    const: leadtek,ltk500hd1829
> > +    enum:
> > +      - leadtek,ltk101b4029w
> > +      - leadtek,ltk500hd1829
> >    reg: true
> >    backlight: true
> >    reset-gpios: true
>