Re: [PATCH] selftests: powerpc: Add header symlinks for building papr character device tests

From: Nathan Lynch
Date: Thu Feb 15 2024 - 14:14:04 EST


Michal Suchanek <msuchanek@xxxxxxx> writes:
>
> Without the headers the tests don't build.
>
> Fixes: 9118c5d32bdd ("powerpc/selftests: Add test for papr-vpd")
> Fixes: 76b2ec3faeaa ("powerpc/selftests: Add test for papr-sysparm")
> Signed-off-by: Michal Suchanek <msuchanek@xxxxxxx>
> ---
> tools/testing/selftests/powerpc/include/asm/papr-miscdev.h | 1 +
> tools/testing/selftests/powerpc/include/asm/papr-sysparm.h | 1 +
> tools/testing/selftests/powerpc/include/asm/papr-vpd.h | 1 +
> 3 files changed, 3 insertions(+)
> create mode 120000 tools/testing/selftests/powerpc/include/asm/papr-miscdev.h
> create mode 120000 tools/testing/selftests/powerpc/include/asm/papr-sysparm.h
> create mode 120000
> tools/testing/selftests/powerpc/include/asm/papr-vpd.h

I really hope making symlinks into the kernel source isn't necessary. I
haven't experienced build failures with these tests. How are you
building them?

I usually do something like (on a x86 build host):

$ make ARCH=powerpc CROSS_COMPILE=powerpc64le-linux- ppc64le_defconfig
$ make ARCH=powerpc CROSS_COMPILE=powerpc64le-linux- headers
$ make ARCH=powerpc CROSS_COMPILE=powerpc64le-linux- -C tools/testing/selftests/powerpc/

without issue.