RE: [PATCH 1/1] Documentation: hyperv: Add overview of PCI pass-thru device support

[Michael Kelley]

From: Easwar Hariharan <eahariha@xxxxxxxxxxxxxxxxxxx> Sent: Thursday, February 15, 2024 10:41 AM
> 
> On 2/14/2024 3:22 PM, mhkelley58@xxxxxxxxx wrote:
> >
> > Add documentation topic for PCI pass-thru devices in Linux guests
> > on Hyper-V and for the associated PCI controller driver (pci-hyperv.c).
> >
> > Signed-off-by: Michael Kelley <mhklinux@xxxxxxxxxxx>
> > ---

[snip]

> > +
> > +With this approach, the vPCI device is a VMBus device and a
> > +PCI device at the same time.  In response to the VMBus offer
> > +message, the hv_pci_probe() function runs and establishes a
> > +VMBus connection to the vPCI VSP on the Hyper-V host.  That
> > +connection has a single VMBus channel.  The channel is used to
> > +exchange messages with the vPCI VSP for the purpose of setting
> > +up and configuring the vPCI device in Linux.  Once the device
> > +is fully configured in Linux as a PCI device, the VMBus
> > +channel is used only if Linux changes the vCPU to be
> > +interrupted in the guest, or
> 
> 
> > ..............................if the vPCI device is removed by
> > +the VM while the VM is running.
> 
> This seems to conflict with the statement called out below. Did you
> mean to say "if the vPCI device is removed *from* the VM..."?
> 

Oops!  Yes, that should be "from the VM".

[snip]

> 
> Otherwise, FWIW
> 
> Reviewed-by: Easwar Hariharan <eahariha@xxxxxxxxxxxxxxxxxxx>
> 

Thanks for reviewing and spotting that error.  I'll see what
other comments accumulate and then send out a v2 with
updates.

Michael