Re: [PATCH] dt-bindings: leds: pwm-multicolour: re-allow active-low

From: Rob Herring
Date: Thu Feb 15 2024 - 10:01:12 EST



On Tue, 13 Feb 2024 20:13:41 +0000, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>
> active-low was lifted to the common schema for leds, but it went
> unnoticed that the leds-multicolour binding had "additionalProperties:
> false" where the other users had "unevaluatedProperties: false", thereby
> disallowing active-low for multicolour leds. Explicitly permit it again.
>
> Fixes: c94d1783136e ("dt-bindings: net: phy: Make LED active-low property common")
> Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> ---
>
> I'm just assuming this is intentionally restrictive, if its not, we
> could easily just change this to uneval: false.
>
> CC: Pavel Machek <pavel@xxxxxx>
> CC: Lee Jones <lee@xxxxxxxxxx>
> CC: Rob Herring <robh@xxxxxxxxxx>
> CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
> CC: Conor Dooley <conor+dt@xxxxxxxxxx>
> CC: Sven Schwermer <sven.schwermer@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> CC: Christian Marangi <ansuelsmth@xxxxxxxxx>
> CC: linux-leds@xxxxxxxxxxxxxxx
> CC: devicetree@xxxxxxxxxxxxxxx
> CC: linux-kernel@xxxxxxxxxxxxxxx
> ---
> Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>

Acked-by: Rob Herring <robh@xxxxxxxxxx>