Re: [PATCH v2] regulator: lp873x: Use bitfield helpers

From: Geert Uytterhoeven
Date: Thu Feb 15 2024 - 08:33:46 EST


Hi Mark,

On Thu, Feb 15, 2024 at 2:13 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Thu, Feb 15, 2024 at 02:09:18PM +0100, Geert Uytterhoeven wrote:
> > Use the FIELD_PREP() helper, instead open-coding the same operation.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > Acked-by: Mark Brown <broonie@xxxxxxxxxx>
>
> Presumably there's some dependency or something which means I would have
> acked this rather than applying it?

Not that I am aware of.

Looking at [1], presumably you were misguided by the bogus threading?
(due to an attempt of mine to send several patches with a single
git-send-email command? I don't remember)

[1] https://lore.kernel.org/all/YZvGFHLWf3GM1jVl@xxxxxxxxxxxxx

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds