Re: [PATCH CFT] usb: ucsi_ccg: Fix command completion handling

[Christian A. Ehrhardt]

Hi Greg,

On Thu, Feb 15, 2024 at 12:07:20PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Feb 15, 2024 at 11:10:24AM +0100, Christian A. Ehrhardt wrote:
> > In case of a spurious or otherwise delayed interrupt
> > it is possible that CCI still reports the previous completion.
> > For this reason the UCSI spec provides different completion
> > bits for normal commands and for UCSI_ACK_CC_CI.
> > 
> > Only complete a sync command if the correct completion bit
> > is set.
> > 
> > This should avoid the need to clear out CCI before starting
> > a command. Thus remove this code.
> > 
> > Signed-off-by: Christian A. Ehrhardt <lk@xxxxxxx>
> > Fixes: e32fd989ac1c ("usb: typec: ucsi: ccg: Move to the new API")
> 
> What does "CFT" in your subject line mean?

It's supposed to mean "Call For Testers". More info in the
"Additional Information" section of the original mail.

I think the change is necessary and good but I do not have the HW
to test it.

I did test a similar change for ucsi_acpi.c that got merged and this
is the ping for ucsi_ccg.c people that they probably need this, too.

   regards   Christian