Re: [PATCH v2 08/15] auxdisplay: linedisp: Provide struct linedisp_ops for future extension

[Geert Uytterhoeven]

Hi Andy,

On Mon, Feb 12, 2024 at 6:04 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> Currently the line display library doesn't scale in case we want to
> provide more operations. Prepare the library to take a newly created
> struct linedisp_ops that scales.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

For the code changes:
Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

> --- a/drivers/auxdisplay/ht16k33.c
> +++ b/drivers/auxdisplay/ht16k33.c
> @@ -696,8 +700,7 @@ static int ht16k33_seg_probe(struct device *dev, struct ht16k33_priv *priv,
>         if (err)
>                 return err;
>
> -       err = linedisp_register(&seg->linedisp, dev, 4, seg->curr,
> -                               ht16k33_linedisp_update);
> +       err = linedisp_register(&seg->linedisp, dev, 4, seg->curr, &ht16k33_linedisp_ops);

Please wrap this long line (everywhere).
All lines in these drivers fit in 80-columns before.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds