Re: [PATCH] drm/msm: Wire up tlb ops

From: Johan Hovold
Date: Thu Feb 15 2024 - 02:35:03 EST


On Tue, Feb 13, 2024 at 09:23:40AM -0800, Rob Clark wrote:
> From: Rob Clark <robdclark@xxxxxxxxxxxx>
>
> The brute force iommu_flush_iotlb_all() was good enough for unmap, but
> in some cases a map operation could require removing a table pte entry
> to replace with a block entry. This also requires tlb invalidation.
> Missing this was resulting an obscure iova fault on what should be a
> valid buffer address.
>
> Thanks to Robin Murphy for helping me understand the cause of the fault.
>
> Cc: Robin Murphy <robin.murphy@xxxxxxx>
> Fixes: b145c6e65eb0 ("drm/msm: Add support to create a local pagetable")

Sounds like you're missing a

Cc: stable@xxxxxxxxxxxxxxx

here? Or is there some reason not to backport this fix (to 5.9 and later
kernels)?

> Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx>

Johan